New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal side effect in roots? #9538
Comments
comment:1
I'm pretty sure this is just #8734. |
comment:3
Replying to @zimmermann6:
Could you try this again? After applying #8734 to 4.5.3.alpha0 (and ignoring the patch rejects), I get sage: var('f6,f5,f4,x')
(f6, f5, f4, x)
sage: e=15*f6*x^2 + 5*f5*x + f4
sage: e.roots(x)
[(-1/30*(sqrt(-12*f4*f6 + 5*f5^2)*sqrt(5) + 5*f5)/f6, 1), (1/30*(sqrt(-12*f4*f6 + 5*f5^2)*sqrt(5) - 5*f5)/f6, 1)] |
comment:4
The patch attached to #8734 indeed fixes this problem. However there are simpler solutions, and I'm not convinced that #8734 is necessary, given that #7377 could solve this in a much cleaner way. Also see the discussion linked from #8734 comment:3: http://groups.google.com/group/sage-devel/browse_thread/thread/67f0a63d00b8d835/06557a921a582f87 In particular, Robert Dodier's suggestion to apply this patch to maxima:
I can confirm that adding these lines to Perhaps this patch is already in a more recent version of maxima? |
comment:5
I confirm that with the #8734 patch applied to 4.5.3 (and ignoring the patch reject) it works However I'm convinced by Burcin's argument. I am ready to review a patch based on this patch Paul |
Attachment: trac_9538-maxima_kill.patch.gz |
comment:6
Here is a maxima package that patches the file http://sage.math.washington.edu/home/burcin/maxima-5.20.1.p1.spkg attachment: trac_9538-maxima_kill.patch adds a doctest to check the example given in the description. |
Author: Robert Dodier, Burcin Erocal |
comment:7
I tried
Did I something wrong? How to install the patched spkg? Paul |
patch for maxima spkg |
comment:8
Attachment: maxima_package.patch.gz Replying to @zimmermann6:
I don't have any experience with the maxima spkg. I just applied the patch in attachment: maxima_package.patchIt works here, but just complains about not being able to build
Perhaps someone more knowledgeable can help out. Building maxima as a library is #8645. |
comment:9
maybe we should wait that #8645 is fixed and merged within Sage to review that ticket. Paul |
comment:10
Adding
directly to the bottom of
without installing http://sage.math.washington.edu/home/burcin/maxima-5.20.1.p1.spkg fixes the problem in the description. |
comment:11
Replying to @zimmermann6:
I have the same problem with the forthcoming 4.6.alpha2, if I've renamed
triggers the behavior. Paul, did you happen to move or rename your Sage root directory? Does Burcin's p1 package install successfully and fix the roots problem with a Sage that has not been moved? |
comment:12
Nils, do you have any thoughts about the problem in comment 7ff? |
comment:13
no, I did all my experiments in /tmp/sage-4.6.alpha1, where I built sage-4.6.alpha1 from source. Paul |
comment:14
Burcin, do you agree that we try Mitesh's solution from comment 10, which avoids installing a new Paul |
comment:15
Replying to @zimmermann6:
Except for So far, it seems the build problem is orthogonal to the problem in the description. |
comment:16
agreed, but how can we proceed in practice so that I can review this ticket? Paul |
apply only this patch -- forget about the package :) |
comment:17
Attachment: trac_9538-maxima_kill.take2.patch.gz I uploaded an alternate patch, attachment: trac_9538-maxima_kill.take2.patchThis issues the |
Reviewer: Paul Zimmermann |
comment:18
ok for the last patch, which fixes the problem, and all tests pass (tested with Sage 4.4.4). Paul PS: a minor remark, is there a mechanism to update the calculus.py patch once the problem is |
comment:19
Thank you for the review. Replying to @zimmermann6:
If it is fixed upstream, this doctest should fail:
Then we can remove the line with the |
comment:20
excellent! Paul |
Merged: sage-4.6.alpha3 |
comment:22
For the record, this fails with maxima-5.22.1:
None of the patches from |
Consider the following with Sage 4.4.4:
This is fine. However:
WTF???
CC: @nbruin
Component: calculus
Keywords: roots, side effect
Author: Robert Dodier, Burcin Erocal
Reviewer: Paul Zimmermann
Merged: sage-4.6.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/9538
The text was updated successfully, but these errors were encountered: