New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary files from spkg/standard #9609
Comments
comment:1
Possibly related: $ cd SAGE_LOCAL/bin
$ grep libdist *
sage-libdist:libdist_filelist = open('%s/spkg/standard/libdist_filelist'%r
sage-libdist: if len(ext) > 1 and not name_without_version in libdist_filelist:
sage-libdist:This is the readme for sage-libdist, which is the
sage-libdist:libdist = 'sage-libdist%s'%r[i:]
sage-libdist:if os.path.exists(libdist):
sage-libdist: os.system('rm -rf %s'%libdist)
sage-libdist:os.system('mv %s %s'%(r,libdist))
sage-libdist:os.system('tar -cvf %s.tar %s'%(libdist,libdist))
sage-libdist:os.system('rm -rf %s'%libdist)
sage-sage: "$SAGE_ROOT"/local/bin/sage-libdist sage-$2.tar
sage-sdist:cp -p $PKGDIR/$STD/libdist_filelist $TMP/$PKGDIR/$STD/ But I can't investigate further right now. |
comment:2
As part of the file "sage-sage":
So sage-libdist is not currently active. I think that we should keep the file libdist_filelist just in case. In my opinion, the other two files can be removed, but I don't know their history. You might ping William about this. |
comment:3
Also, as mpatel points out: the script sage-sdist tries to copy libdist_filelist, so that may break with this file missing. |
comment:4
Okay, it looks like we should put libdist_filelist back in (and then, in my opinion, find out why it's there and if possible, open a ticket for removing it and the parts of the scripts that reference it). The numeric-24.2.txt is a short description of a Python module that we don't ship. Even if we did include it, I can see no reason why such a file should be kept in spkg/standard. notes.txt refers to the sage_c_lib package, which no longer exists, and to a very outdated version of linbox. The libtool information in that file should be kept in the linbox spkg and/or put on the wiki. I think we can resolve this ticket by just putting libdist_filelist back. |
comment:5
Sounds good to me. We can always recover the other files from an old tarball if we ever need them. |
Reviewer: John Palmieri |
comment:7
I'm including 4.5.2.alpha0's |
Merged: sage-4.5.2.rc0 |
Dan Drake wrote on sage-release:
The files
libdist_filelist
,notes.txt
, andnumeric-24.2.txt
have been removed from Sage 4.5.2.alpha1:This ticket is for reviewing the change.
CC: @dandrake
Component: build
Author: Dan Drake
Reviewer: John Palmieri
Merged: sage-4.5.2.rc0
Issue created by migration from https://trac.sagemath.org/ticket/9609
The text was updated successfully, but these errors were encountered: