constructor for the all ones matrix

[rlmill]

CC: @jdemeyer

Component: user interface

Author: Robert Miller

Reviewer: Felix Lawrence

Merged: sage-4.6.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9685

[rlmill]

Attachment: trac_9685.patch.gz

[sagetrac-flawrence]

comment:2

Worked for me and behaves consistently with similar functions such as zero_matrix(). The sparse matrix option is not too useful here (since the matrix gets filled with ones), but I guess it's best to be consistent with similar functions, which the patch is.

[sagetrac-flawrence]

Reviewer: Felix Lawrence

[jdemeyer]

comment:3

When applying this to sage-4.6.1.alpha0, I get

patching file sage/matrix/constructor.py
Hunk #1 succeeded at 1348 with fuzz 2 (offset 363 lines).

So the patch succeeds, but it's probably better if it gets rebased properly.

[sagetrac-flawrence]

comment:4

If I rebased it, would someone else then have to review it?

[jdemeyer]

comment:5

Replying to @sagetrac-flawrence:

If I rebased it, would someone else then have to review it?

I could easily review your rebasing.

[sagetrac-flawrence]

rebased version of original patch

[sagetrac-flawrence]

comment:6

Attachment: trac_9685-rebased.patch.gz

[jdemeyer]

Merged: sage-4.6.1.alpha1