Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix2.pyx: replace "x < 1e-15" by "abs(x) < 1e-15" #9765

Closed
jhpalmieri opened this issue Aug 18, 2010 · 4 comments
Closed

matrix2.pyx: replace "x < 1e-15" by "abs(x) < 1e-15" #9765

jhpalmieri opened this issue Aug 18, 2010 · 4 comments
Assignees
@aghitza
Labels
c: algebra p: blocker / 1 t: bug
Milestone
sage-4.5.3

Comments

@jhpalmieri
Copy link
Member

In matrix2.pyx, there is a doctest (line 6406):

            sage: all(imag(e) < 1.1e-15 for e in eigs)

We should replace "imag(e)" by "abs(imag(e))".

The attached patch depends on #9760.

Component: algebra

Author: John Palmieri

Reviewer: Mitesh Patel

Merged: sage-4.5.3.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/9765
@jhpalmieri jhpalmieri added this to the sage-4.6 milestone Aug 18, 2010
@jhpalmieri
Copy link
Member Author

comment:1

Attachment: trac_9765-matrix2-abs.patch.gz

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 23, 2010

Reviewer: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 23, 2010

comment:2

The test still passes on bsd, redhawk, sage, and t2.math.

@qed777 qed777 mannequin modified the milestones: sage-4.6, sage-4.5.3 Aug 23, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 24, 2010

Merged: sage-4.5.3.alpha2

@qed777 qed777 mannequin removed the s: positive review label Aug 24, 2010
@qed777 qed777 mannequin closed this as completed Aug 24, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: algebra p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-4.5.3
Development

No branches or pull requests
2 participants
@aghitza @jhpalmieri