Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting rid of endianness-dependent behaviour in GAP random sources #9867

Closed
dimpase opened this issue Sep 7, 2010 · 7 comments
Closed

getting rid of endianness-dependent behaviour in GAP random sources #9867

dimpase opened this issue Sep 7, 2010 · 7 comments

Comments

@dimpase
Copy link
Member

dimpase commented Sep 7, 2010

in the thread [How to deal with GAP's machine dependent random generator?] on sage-devel Simon King mentioned that GAP own random source dependes on endianness of the machine.
While Sage sort of takes care of this in misc/randstate.pyx,
it still does not fix GAP internals. So, to make it good and proper, we essentially add the fix in misc/randstate.pyx to GAPROOT/src/integer.c, and remove it from misc/randstate.pyx
The updated gap spkg is here:

http://boxen.math.washington.edu/home/dima/packages/gap-4.4.12.p5.spkg

So one needs to install this spkg and apply the patch attached to the ticket. I don't seem to have access to a 64-bit big-endian system, so it would be great to test it there, just in case...

Upstream: Fixed upstream, in a later stable release.

CC: @simon-king-jena

Component: group theory

Reviewer: Dmitrii Pasechnik, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/9867

@dimpase dimpase added this to the sage-5.4 milestone Sep 7, 2010
@dimpase
Copy link
Member Author

dimpase commented Sep 7, 2010

comment:1

Attachment: trac_9876_gap_MT_endianness.patch.gz

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Sep 8, 2010

Changed upstream from Completely fixed; Fix reported upstream to Fixed upstream, but not in a stable release.

@dimpase
Copy link
Member Author

dimpase commented Sep 25, 2012

comment:4

This will be fixed in #13211. Let us close this one as obsolete.

@kcrisman
Copy link
Member

Reviewer: Dmitrii Pasechnik, Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:5

I can confirm that the current code is no longer needed as of #13211; see here.

@kcrisman kcrisman removed this from the sage-5.4 milestone Sep 25, 2012
@jdemeyer
Copy link

jdemeyer commented Oct 5, 2012

Changed upstream from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants