Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for NZMATH/Sage interoperation #9915

Closed
sagetrac-cwitty mannequin opened this issue Sep 16, 2010 · 7 comments
Closed

fixes for NZMATH/Sage interoperation #9915

sagetrac-cwitty mannequin opened this issue Sep 16, 2010 · 7 comments

Comments

@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Sep 16, 2010

NZMATH uses a subtype of Python's "long" for its bignum type. This works fine with plain mpmath, but when mpmath runs under Sage it uses Cython code that's incompatible with NZMATH. This patch fixes mpmath-under-sage to fix some incompatibilities with NZMATH. (It also modifies ZZ to allow initialization from a subclass of int/long/float.)

Component: basic arithmetic

Keywords: NZMATH

Author: Carl Witty

Reviewer: Leif Leonhardy

Merged: sage-4.6.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/9915

@sagetrac-cwitty sagetrac-cwitty mannequin added this to the sage-4.6 milestone Sep 16, 2010
@sagetrac-cwitty sagetrac-cwitty mannequin assigned aghitza Sep 16, 2010
@sagetrac-cwitty
Copy link
Mannequin Author

sagetrac-cwitty mannequin commented Sep 16, 2010

Attachment: trac9915_nzmath-mpmath-fixes.patch.gz

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 16, 2010

comment:2

Any additional (--[only-]optional[=...]) tests to run with NZMATH installed?

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 16, 2010

comment:3

Patch looks reasonable, and doesn't cause additional doctest failures when running ptestlong on (not yet released) Sage 4.6.alpha1 (with NZMATH 1.0.0 installed; Ubuntu 10.04 x86_64).

Positive review so far, still looking for optional NZMATH doctests... ;-)

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 16, 2010

Reviewer: Leif Leonhardy

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 16, 2010

comment:4

Replying to @nexttime:

... still looking for optional NZMATH doctests... ;-)

Couldn't find any; also, NZMATH doesn't have an spkg-check file.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 16, 2010

comment:5

Is

sage: from nzmath import *

supposed to work? (Gives deprecation warnings and an attribute error.)

But the following works:

sage: import nzmath.rational
sage: r = nzmath.rational.Rational(113r, 355r)
sage: print r
113/355
sage: 

That's of course not much of a test. ;-)

@qed777
Copy link
Mannequin

qed777 mannequin commented Sep 29, 2010

Merged: sage-4.6.alpha2

@qed777 qed777 mannequin removed the s: positive review label Sep 29, 2010
@qed777 qed777 mannequin closed this as completed Sep 29, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant