New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
triangulate point configurations #9918
Comments
comment:2
Passes tests, coverage, documentation looks good. Nice work! I haven't tested with TOPCOM but I don't think that's necessary since everything works without it. |
Reviewer: Marshall Hampton |
comment:4
For the record:
I am not sure what we are supposed to do with this (personally, I like to have references in the file where they are referenced), but the documentation does not build without warnings... |
comment:5
See also: https://groups.google.com/d/topic/sage-devel/26YSkYOztus/discussion Until there is a proper way of dealing with duplicate references, I think it is best to keep the warning around. The alternatives all suck... |
comment:6
Replying to @novoselt:
I'm afraid a Sphinx warning is sufficient reason for needs_work... |
Attachment: trac_9918_triangulate_point_configurations.patch.gz Updated patch |
comment:7
Fine, if lack of warnings is more important than usefulness of the documentation. I removed the text of the citation, leaving only the link to the same citation a different module. Now Sphinx doesn't complain any more. |
Merged: sage-4.6.2.alpha3 |
The attached patch implements triangulations of point configurations in arbitrary dimensions in Sage/Cython/C++ without relying on TOPCOM.
The internal implementation covers finding a single triangulation as well as enumerating all triangulations connected to it by bistellar flips. TOPCOM is required to test for regularity and/or to find non-connected triangulations.
While not quite as fast, my limited testing shows the performance to be in the same order of magnitude as TOPCOM:
See also #8169: include TOPCOM, where an optional spkg is being worked on.
CC: @sagetrac-mhampton @novoselt
Component: geometry
Author: Volker Braun
Reviewer: Marshall Hampton
Merged: sage-4.6.2.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/9918
The text was updated successfully, but these errors were encountered: