This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
some modernizing of imports, toward python3 compatible imports #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| import cPickle as pickle | ||
| except ImportError: | ||
| import pickle |
There was a problem hiding this comment.
I haven't trawled through the sagenb source enough to be sure if it's worth bothering, but if it used the six module it would handle stuff like this as well.
fchapoton
changed the title
|
is it better now ? could it be merged ? |
|
Could my 3 pull requests be merged before making a new release, please ? Unless there is some objection ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as another small step towards python3, convert some of the imports
to the python3 absolute or relative import syntax.
Also changed some
ur"""ror"""