removal of oldsessions

[fchapoton]

that is apparently not used anywhere

[kcrisman]

See #184 where this was added because of some flask issues. I guess I would make sure to have people try this out a reasonable amount before getting rid of it - especially if there isn't a big reason to 'clean up' bad code here. The last thing we want is sagenb breaking abruptly instead of going quietly into the night.

[embray]

I guess the question is, what motivated this, and can you be sure it isn't being used?

[fchapoton]

(1) motivation is : "removing dead branches" as cleanup service
(2) git grep "oldsessions" returns nothing

[kcrisman]

Yes, I noticed (2) as well. But I think it was the kind of thing that really did break sagenb. Here is the relevant flask documentation:

The biggest change going from 0.9 to 0.10 is that the cookie serialization format changed from pickle to a specialized JSON format. This change has been done in order to avoid the damage an attacker can do if the secret key is leaked. When you upgrade you will notice two major changes: all sessions that were issued before the upgrade are invalidated and you can only store a limited amount of types in the session.

It seems that sage-on-gentoo (which is usually pretty good about removing unneeded stuff) still has it, see e.g. https://github.com/cschwan/sage-on-gentoo/blob/master/sci-mathematics/sage-notebook/sage-notebook-1.1.2.ebuild