Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
#25463: finish pyflaking elliptic_curves
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnCremona committed May 30, 2018
1 parent 596f49f commit 2a7282a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 15 deletions.
18 changes: 7 additions & 11 deletions src/sage/schemes/elliptic_curves/BSD.py
Expand Up @@ -332,14 +332,12 @@ def prove_BSD(E, verbosity=0, two_desc='mwrank', proof=None, secs_hi=5,
p = 2: True by 2-descent
True for p not in {2, 3, 5} by Kolyvagin.
Kolyvagin's bound for p = 3 applies by Lawson-Wuthrich
Kolyvagin's bound for p = 5 applies by Lawson-Wuthrich
True for p = 3 by Kolyvagin bound
Remaining primes:
p = 5: reducible, not surjective, additive, divides a Tamagawa number
(no bounds found)
ord_p(#Sha_an) = 0
[5]
True for p = 5 by Kolyvagin bound
[]
sage: E.prove_BSD(two_desc='simon')
[5]
[]
A rank two curve::
Expand Down Expand Up @@ -395,11 +393,9 @@ def prove_BSD(E, verbosity=0, two_desc='mwrank', proof=None, secs_hi=5,
sage: E.prove_BSD(verbosity=2)
p = 2: True by 2-descent
True for p not in {2, 5} by Kolyvagin.
Remaining primes:
p = 5: reducible, not surjective, good ordinary, divides a Tamagawa number
(no bounds found)
ord_p(#Sha_an) = 0
[5]
Kolyvagin's bound for p = 5 applies by Lawson-Wuthrich
True for p = 5 by Kolyvagin bound
[]
A curve for which 3 divides the order of the Tate-Shafarevich group::
Expand Down
8 changes: 4 additions & 4 deletions src/sage/schemes/elliptic_curves/padic_lseries.py
Expand Up @@ -1624,10 +1624,10 @@ def Dp_valued_height(self,prec=20):
n = arith.LCM(E.tamagawa_numbers())
n = arith.LCM(n, E.Np(p)) # allowed here because E has good reduction at p

if p < 5:
phi = self.frobenius(min(6,prec),algorithm="approx")
else:
phi = self.frobenius(prec+2,algorithm="mw")
# if p < 5:
# phi = self.frobenius(min(6,prec),algorithm="approx")
# else:
# phi = self.frobenius(prec+2,algorithm="mw")

def height(P,check=True):
if P.is_finite_order():
Expand Down

0 comments on commit 2a7282a

Please sign in to comment.