Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
improve documentation of EllipticCurve_number_field.gens()
Browse files Browse the repository at this point in the history
  • Loading branch information
pjbruin committed Mar 28, 2014
1 parent 2c985ee commit 318230a
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 6 deletions.
24 changes: 19 additions & 5 deletions src/sage/schemes/elliptic_curves/ell_number_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -2034,11 +2034,14 @@ def rank(self,verbose=0, lim1=2, lim3=4, limtriv=2, maxprob=20, limbigprime=30):

def gens(self,verbose=0, lim1=2, lim3=4, limtriv=2, maxprob=20, limbigprime=30):
r"""
Returns some points of infinite order on this elliptic curve.
They are not necessarily linearly independent.
Return some points of infinite order on this elliptic curve.
Check :meth:`~rank` or
:meth:`~rank_bounds` to verify the number of generators.
Contrary to what the name of this method suggests, the points
it returns do not always generate a subgroup of full rank in
the Mordell-Weil group, nor are they necessarily linearly
independent. Moreover, the number of points can be smaller or
larger than what one could expect after calling :meth:`~rank`
or :meth:`~rank_bounds`.
.. NOTE::
Expand Down Expand Up @@ -2080,6 +2083,17 @@ def gens(self,verbose=0, lim1=2, lim3=4, limtriv=2, maxprob=20, limbigprime=30):
sage: E.gens()
[(0 : 0 : 1), (1/8*a + 5/8 : -3/16*a - 7/16 : 1)]
It can happen that no points are found if the height bounds
used in the search are too small (see :trac:`10745`)::
sage: K.<y> = NumberField(x^4 + x^2 - 7)
sage: E = EllipticCurve(K, [1, 0, 5*y^2 + 16, 0, 0])
sage: E.rank()
1
sage: E.gens(lim1=1, lim3=1)
[]
sage: E.gens() # long time (about 3 s)
[(-369/25*y^3 + 539/25*y^2 - 1178/25*y + 1718/25 : -27193/125*y^3 + 39683/125*y^2 - 86816/125*y + 126696/125 : 1)]
Here is a curve of rank 2, yet the list contains many points::
Expand All @@ -2101,7 +2115,7 @@ def gens(self,verbose=0, lim1=2, lim3=4, limtriv=2, maxprob=20, limbigprime=30):
sage: E.rank()
2
Test that the points of finite order are not included :trac: `13593` ::
Test that points of finite order are not included (see :trac:`13593`)::
sage: E = EllipticCurve("17a3")
sage: K.<t> = NumberField(x^2+3)
Expand Down
2 changes: 1 addition & 1 deletion src/sage/schemes/elliptic_curves/gp_simon.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def simon_two_descent(E, verbose=0, lim1=None, lim3=None, limtriv=None, maxprob=
Check that :trac:`16022` is fixed::
sage: K.<y> = NumberField(x^4 + x^2 - 7);
sage: K.<y> = NumberField(x^4 + x^2 - 7)
sage: E = EllipticCurve(K, [1, 0, 5*y^2 + 16, 0, 0])
sage: E.simon_two_descent(lim1=2, limtriv=3) # long time (about 3 s)
(1, 1, ...)
Expand Down

0 comments on commit 318230a

Please sign in to comment.