Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
trac #17534: Reviewers' comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanncohen committed Dec 22, 2014
1 parent 4ae1934 commit a4615b0
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/doc/en/developer/reviewer_checklist.rst
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ You are now ready to change the ticket's status (see
:ref:`section-trac-ticket-status`):

- **positive review**: if the answers to the questions above and other
reasonable questions are *"yes"*, you can give the patch a positive review.
reasonable questions are *"yes"*, you can set the ticket to
``positive_review``. Add your full name to the "reviewer" field (see
:ref:`section-trac-fields`).

- **needs_review**: if something is not as it should, write a list of all points
- **needs_work**: if something is not as it should, write a list of all points
that need to be addressed in a comment and change the ticket's status to
``needs_review``.
``needs_work``.

- **needs_info**: if something is not clear to you and prevents you from going
further with the review, ask your question and set the ticket's status to
Expand All @@ -102,7 +104,7 @@ For more advice on reviewing, see [WSblog]_.

The point of the review is to ensure that the Sage code guidelines
are followed and that the the implementation is mathematically
correct. Please refrain from aditional feature requests or
correct. Please refrain from additional feature requests or
open-ended discussion about alternative implementations. If you
want the patch written differently, your suggestion should be a
clear and actionable request.
Expand Down

0 comments on commit a4615b0

Please sign in to comment.