Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter: File --> Download As --> PDF should first save #33

Closed
williamstein opened this issue Jun 24, 2015 · 6 comments
Closed

Jupyter: File --> Download As --> PDF should first save #33

williamstein opened this issue Jun 24, 2015 · 6 comments

Comments

@williamstein
Copy link
Contributor

When selecting File --> Download As --> PDF in Jupyter notebook, SMC should first do a save then do the download, since otherwise it prints an old version.

screen shot 2015-06-23 at 10 41 42 pm

This is probably caused by us possibly disabling the save internally in Jupyter's javascript (not sure).

Reported by: Troels Emtekær Linnet

@tlinnet
Copy link

tlinnet commented Jun 24, 2015

I can confirm that "save first" -> "then pdf" effectively solves the problem.
I hope this can be automated, since I often "forget it".
Thank you!

@williamstein
Copy link
Contributor Author

@jasongrout -- any thoughts about this?

@jasongrout
Copy link
Contributor

uh, yes, it makes sense to save before downloading. I'll see if it does that normally.

@jasongrout
Copy link
Contributor

By default, it seems that the notebook saves before downloading for me downloading a .py file. However, downloading as a pdf isn't working for me right now, so I didn't test that.

@williamstein
Copy link
Contributor Author

I can definitely confirm that this behavior persists on SageMathCloud. Downloading pdf's is working fine for me, but definitely shows the version before save. Also, print preview shows the pre-save version.

@williamstein
Copy link
Contributor Author

this was a bug in jupyter, but it is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants