multiple definition of `__packed' - build error with gcc 10

[plusky]

Starting from the upcoming GCC release 10, the default of -fcommon option will change to -fno-common - this leads to build errors we observe in openSUSE Factory:

[   45s] libtool: link:  gcc -shared  -fPIC -DPIC  .libs/libiscsi_la-connect.o .libs/libiscsi_la-crc32c.o .libs/libiscsi_la-discovery.o .libs/libiscsi_la-init.o .libs/libiscsi_la-login.o .libs/libiscsi_la-nop.o .libs/libiscsi_la-pdu.o .libs/libiscsi_la-iscsi-command.o .libs/libiscsi_la-scsi-lowlevel.o .libs/libiscsi_la-socket.o .libs/libiscsi_la-sync.o .libs/libiscsi_la-task_mgmt.o .libs/libiscsi_la-logging.o .libs/libiscsi_la-iser.o   -libverbs -lrdmacm -lgcrypt  -O2 -fstack-protector-strong -flto=auto -g -flto=auto   -Wl,-soname -Wl,libiscsi.so.9 -Wl,-version-script -Wl,.libs/libiscsi.ver -o .libs/libiscsi.so.9.0.0
[   45s] /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: .libs/libiscsi_la-iser.o (symbol from plugin): in function `iscsi_init_iser_transport':
[   45s] (.text+0x0): multiple definition of `__packed'; .libs/libiscsi_la-init.o (symbol from plugin):(.text+0x0): first defined here
[   45s] collect2: error: ld returned 1 exit status
[   45s] make[2]: *** [Makefile:439: libiscsi.la] Error 1
[   45s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libiscsi-1.19.0/lib'
[   45s] make[1]: *** [Makefile:497: all-recursive] Error 1
[   45s] make: *** [Makefile:385: all] Error 2
[   45s] error: Bad exit status from /var/tmp/rpm-tmp.hWtBH1 (%build)

See also:
https://bugzilla.suse.com/show_bug.cgi?id=1160276
https://bugzilla.suse.com/show_bug.cgi?id=1160244

[bvanassche]

Do you agree that pull request #307 should fix this issue?

[sahlberg]

Merged.

…

On Thu, Jan 9, 2020 at 12:26 PM Bart Van Assche ***@***.***> wrote: Do you agree that pull request #307 <#307> should fix this issue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#308?email_source=notifications&email_token=AADY3EGMGENGJSRZY4ASUTLQ42DN3A5CNFSM4KEERG72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIOWPIY#issuecomment-572352419>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADY3EC2MLNIHB7JXIWX4PLQ42DN3ANCNFSM4KEERG7Q> .