four little patches #307
Merged
four little patches #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSER header is followed by iSCSI PDU without any pad in an RCaP Message. Signed-off-by: wanghonghao <wanghonghao@bytedance.com>
bvanassche
requested changes
Dec 9, 2019
include/iser-private.h
Outdated
| @@ -158,7 +158,7 @@ struct iser_tx_desc { | |||
| struct iser_cm_hdr { | |||
| uint8_t flags; | |||
| uint8_t rsvd[3]; | |||
| } __packed; | |||
| } __attribute__((packed)); | |||
There was a problem hiding this comment.
Applying attribute((packed)) to an entire data structure can make gcc 9 unhappy. Since attribute((packed)) is not necessary for this data structure, please consider removing "__packed" entirely. See also https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Warning-Options.html#index-Waddress-of-packed-member
There was a problem hiding this comment.
Ok, it's unnecessary and I've removed it.
`__packed` is not defined previously, and was treated as a varible declaration. Signed-off-by: wanghonghao <wanghonghao@bytedance.com>
When ImmediateData=Yes, DataSegmentLength is set in iSCSI layer but immediate data is not sent in the RCaP message. Signed-off-by: wanghonghao <wanghonghao@bytedance.com>
A PDU is sent directly in iscsi_iser_queue_pdu even if the cmdsn of it exceeds maxcmdsn, and it may be ignored by the target. Signed-off-by: wanghonghao <wanghonghao@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.