Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use multipath for secondary sessions (if available) instead of reconnecting #182

Merged
merged 5 commits into from
Sep 29, 2015
Merged

use multipath for secondary sessions (if available) instead of reconnecting #182

merged 5 commits into from
Sep 29, 2015

Conversation

ddiss
Copy link
Contributor

@ddiss ddiss commented Sep 21, 2015 

 test-tool/iscsi-multipath.c                 |  57 +++++++++++
 test-tool/iscsi-multipath.h                 |   4 +
 test-tool/test_preventallow_2_itnexuses.c   |  19 ++--
 test-tool/test_prout_reserve_access.c       | 104 +++++++-------------
 test-tool/test_prout_reserve_ownership.c    | 104 +++++++-------------
 test-tool/test_reserve6_2initiators.c       |  31 +++---
 test-tool/test_reserve6_itnexus_loss.c      |  23 ++---
 test-tool/test_reserve6_logout.c            |  23 ++---
 test-tool/test_reserve6_target_cold_reset.c |  21 ++--
 test-tool/test_reserve6_target_warm_reset.c |  22 ++---
 test-tool/test_sanitize_readonly.c          |  19 ++--
 test-tool/test_sanitize_reservations.c      |  17 ++--
 12 files changed, 195 insertions(+), 249 deletions(-)

@ddiss
test/multipath: add helper to obtain secondary sessions
0cfc593 
A number of existing tests create a secondary iSCSI session by logging
into the target specified in the base sd during the test.

With multipath sessions now connected during iscsi-test-cu startup
(when launched with multiple URIs), secondary sessions can be
provided via multipath when available, rather than reconnecting.

This change adds a helper that conditionally returns the secondary
multipath device if available, or falls back to creating a new session
via the base sd target details.

Signed-off-by: David Disseldorp <ddiss@suse.de>
@ddiss
test/reserve6: use multipath session if available
89c1749 
Many tests currently reconnect to the base sd for multi-initiator
testing. Use the secondary multipath device instead, if available.

Signed-off-by: David Disseldorp <ddiss@suse.de>
@ddiss
test/prout: use multipath session if available
638d58d 
These tests currently reconnect to the base sd for multi-initiator
testing. Use the secondary multipath device instead, if available.

Signed-off-by: David Disseldorp <ddiss@suse.de>
@ddiss
test/sanitize: use multipath session if available
69d9a77 
These tests currently reconnect to the base sd for multi-initiator
testing. Use the secondary multipath device instead, if available.

Signed-off-by: David Disseldorp <ddiss@suse.de>
@ddiss
test/preventallow: use multipath session if available
4f55a3f 
This test currently reconnects to the base sd for multi-initiator
testing. Use the secondary multipath device instead, if available.

Signed-off-by: David Disseldorp <ddiss@suse.de>
@ddiss
Copy link
Contributor Author

ddiss commented Sep 28, 2015

Ping - any thoughts on these changes?

sahlberg added a commit that referenced this pull request Sep 29, 2015
@sahlberg
Merge pull request #182 from ddiss/mp_instead_of_reconnect
46e606f 
use multipath for secondary sessions (if available) instead of reconnecting
@sahlberg sahlberg merged commit 46e606f into sahlberg:master Sep 29, 2015
@sahlberg
Copy link
Owner

merged, thanks!

On Mon, Sep 28, 2015 at 2:59 AM, David Disseldorp notifications@github.com
wrote:

Ping - any thoughts on these changes?

—
Reply to this email directly or view it on GitHub
#182 (comment).

@ddiss ddiss deleted the mp_instead_of_reconnect branch September 29, 2015 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddiss @sahlberg