Add wheel to pypi when push a tag #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
17 tasks
Trinkle23897
pushed a commit
that referenced
this pull request
Mar 20, 2023
## Description - close #246 - further speedup - [support custom node type registration](pytorch/pytorch#65761 (comment)) ## Motivation and Context <!--Why is this change required? What problem does it solve?--> <!--If it fixes an open issue, please link to the issue here.--> <!--You can use the syntax `close #233` if this solves the issue #233--> Initial Test Results: ### Test gym TreeValue: <img width="1073" alt="image" src="https://user-images.githubusercontent.com/32269413/221405036-ed1d1692-714b-4af7-a011-8accb36b8427.png"> OpTree: <img width="1074" alt="image" src="https://user-images.githubusercontent.com/32269413/221405130-521b48fe-7760-4ef0-8abb-bc9468c7bdeb.png"> ### Test dmc TreeValue: <img width="1061" alt="image" src="https://user-images.githubusercontent.com/32269413/221405292-69f2b96e-d590-42a5-b073-da4721ec6148.png"> OpTree: <img width="1076" alt="image" src="https://user-images.githubusercontent.com/32269413/221405305-e1d53f94-5f97-4c11-a20c-c167fdd9d45b.png"> - [x] I have raised an issue to propose this change ([required](https://envpool.readthedocs.io/en/latest/pages/contributing.html) for new features and bug fixes) ## Types of changes What types of changes does your code introduce? Put an `x` in all the boxes that apply: - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds core functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Example (update in the folder of example) ## Checklist Go over all the following points, and put an `x` in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help! - [x] I have read the [CONTRIBUTION](https://envpool.readthedocs.io/en/latest/pages/contributing.html) guide (**required**) - [ ] My change requires a change to the documentation. - [x] I have updated the tests accordingly (*required for a bug fix or a new feature*). - [ ] I have updated the documentation accordingly. - [x] I have reformatted the code using `make format` (**required**) - [x] I have checked the code using `make lint` (**required**) - [x] I have ensured `make bazel-test` pass. (**required**) cc @XuehaiPan --------- Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
17 tasks
15 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.