Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated usage of JAX symbols. #282

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

ethanluoyc
Copy link
Contributor

@ethanluoyc ethanluoyc commented Oct 24, 2023

Description

Remove deprecated JAX symbols.

Motivation and Context

  • jax.abstract_array.ShapedArray is removed for jax>=0.4.16. See

https://github.com/google/jax/blob/main/CHANGELOG.md#jax-0416-sept-18-2023

  • xla_client.register_cpu_custom_call_target is removed in

openxla/xla@0ab5486

close #281

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • New environment (non-breaking change which adds 3rd-party environment)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Fix deprecated symbol

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make bazel-test pass. (required)

* `jax.abstract_array.ShapedArray` is removed for jax>=0.4.16. See

https://github.com/google/jax/blob/main/CHANGELOG.md#jax-0416-sept-18-2023

* `xla_client.register_cpu_custom_call_target` is removed in

openxla/xla@0ab5486
@mavenlin
Copy link
Member

@ethanluoyc Thanks for fixing the bug!
The code change looks good to me, but it seems some tests are broken.

@Trinkle23897
Copy link
Collaborator

I’ll fix it tmr

@mavenlin mavenlin mentioned this pull request Oct 26, 2023
14 tasks
@Trinkle23897 Trinkle23897 merged commit a9d2ec9 into sail-sg:main Oct 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] XLA interface does not work with jax>=0.4.16
3 participants