Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Make PhoneMemory-folder user-configurable #15

Open
Olf0 opened this issue Feb 19, 2022 · 2 comments · Fixed by #46
Open

[Suggestion] Make PhoneMemory-folder user-configurable #15

Olf0 opened this issue Feb 19, 2022 · 2 comments · Fixed by #46
Labels
enhancement Enhances something feature request feature requests, suggestions, ideas etc. help wanted Extra attention is needed

Comments

@Olf0
Copy link
Collaborator

Olf0 commented Feb 19, 2022

Original title:

[Bug] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible


@llewelld I was surprised to see, that I cannot simply select /home/nemo as my default folder in FileCase ≥ 0.2.1, but was relieved for a second when I found your commit 7369833 with its headline and description:
Remove hardcoded references to /home/nemo
Moves the definition of the home folder into the settings file and defaults to /home/defaultuser.

But then I discovered, that:

  • One cannot change this setting at the GUI: This is an unsurmountable obstacle for many.
  • The new settings option is called "home", which is in stark contrast to all other options being multi-word options in "CamelCase" and the term used at the GUI ("Phone memory").
  • Any documentation or a simple description how to use this is lacking: I did that in the section "TL;DR" here.
  • Side note: The default value is /home/defaultuser, not /home/default as denoted in the headline of commit 7369833.
  • The unconditional introduction of a new default value (/home/defaultuser) for a new setting (home) breaks extant installations of FileCase, which were using /home/nemo, when updating them to any version ≥ 0.2.1.

IMO performing this change in such a manner is a bit "evil", because it will leave many helplessly stranded. It took me more than 15 minutes of research and testing to comprehend how to utilise this correctly.

My criticism ultimately is, that this commit is only a half-step towards implementing a GUI option in FileCase's settings to make this option accessible for an average user.
My suggestion is to offer /home/nemo and /home/defaultuser as predefined values, but to allow for inputting any path.

Hence I suggested via PR #14 (merged) to alter settings option "home" to "PhoneMemoryFolder", because that is what it is called at the GUI, is more self-explanatory and is aligned with extant option names (e.g., in "CamelCase").

But this still leaves the ToDo open to implement a GUI option for setting this in FileCase's settings page.

TL;DR (documenting the current workaround for others)

  • One can set the default folder to be used as "Phone memory" folder by adding a line to ~/.config/cepiperez/fileboxplus.conf in the [General] section since FileCase 0.2.1, e.g., home=/home/nemo
    For releases after PR config.cpp: Alter option "home"→"PhoneMemoryFolder" #14 (i.e., FileCase > 0.4.0) this is, e.g., PhoneMemoryFolder=/home/nemo
  • To achieve that with FileCase:
    1. One has to enable "Show root filesystem" and "Show hidden files" in FileCase's settings.
    2. Then ascend and descend into the real user's home directory (e.g., /home/nemo) and there into .config/cepiperez
    3. Tap on the file fileboxplus.conf, select "Rename" in the pulley menu and append the extension .txt
    4. Then tap on the file fileboxplus.conf.txt, select "Edit" in the pulley menu and add aforementioned line in the [General] section.
    5. Ultimately tap on the file fileboxplus.conf.txt again, select "Rename" in the pulley menu and remove the extension .txt, so that the file is called fileboxplus.conf again.
@Olf0 Olf0 closed this as completed in #46 Nov 5, 2023
Olf0 pushed a commit that referenced this issue Nov 5, 2023
Closes #15
This should return the current user's home directory instead of hard-coding it.
Documentation reference: https://doc.qt.io/qt-5/qstandardpaths.html
Alternatively, [`QDir::homePath](https://doc.qt.io/qt-5/qdir.html#homePath) can be used.
(not actually tested)
@Olf0
Copy link
Collaborator Author

Olf0 commented Nov 16, 2023

Likely "the best solution would be to use the home dir as default and let users change it if desired", as @simonschmeisser denoted.

@Olf0 Olf0 reopened this Nov 16, 2023
@Olf0 Olf0 added enhancement Enhances something help wanted Extra attention is needed labels Nov 16, 2023
@Olf0
Copy link
Collaborator Author

Olf0 commented Feb 7, 2024

What remains, is that it is not nice that one cannot set the default path (but one of multiple, manually user-selectable "default locations") in the GUI: not really a big issue.

P.S.: For a suggestion for a more elegant solution, see issue #67.

@Olf0 Olf0 changed the title "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible [~~Bug~~ Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible Feb 7, 2024
@Olf0 Olf0 changed the title [~~Bug~~ Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible [Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible Feb 7, 2024
@Olf0 Olf0 added the feature request feature requests, suggestions, ideas etc. label Feb 7, 2024
@Olf0 Olf0 changed the title [Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible [Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible Feb 7, 2024
@Olf0 Olf0 changed the title [Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible [Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible Feb 7, 2024
@Olf0 Olf0 changed the title [Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible [Suggestion] Make PhoneMemory-folder user-configurable Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances something feature request feature requests, suggestions, ideas etc. help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant