-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM3 suggestion] Retrieve the installed SFOS version by using 'version', not 'ssu re' #33
Comments
Oh, pardon me, Patchmanager 3.0.55 does all that almost fine! Background: Observations: Conclusion: |
SSU target release is set to 3.0.0.8 every day or reboot (by the "something"), which makes this issue is a little annoying. |
Oh, I missed to denote here, that I was able to identify the "evil something" in May 2019: But after all, the baseline still is: Do not use |
Meh, why not just use [1] https://www.freedesktop.org/software/systemd/man/os-release.html# |
Correct, but that is not the point of this issue #33. |
I realize that, and you propose the use of I argue a better replacement is the file because
|
O.K., an explicit "Ack" this time, than just a "thumbs up: 👍" and an implicit "Correct, ...". Side note: What I missed in your first reply, was something along the line "I realise that ...", which confirms a mutual / common understanding of the basic issue. |
As suggested by sailfishos-patches#33. Probably not important for ports.
Thank you @elros34 for implementing this change per your "PM2-forever" commit @nephros can you please check that commit |
Nice find, good work. Code seems fine, but:
|
The answer is no, as the codebase this modifies is ancient and we are doing things differently in pm3 than was done in pm2. (E.g. we call the ssu dbus service from C++ not QML). However concept can likely be ported - I like the usage of QSettings to read and parse the |
See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
This should do the same - however I'm not sure how exactly to test it. Of course editing So please test, review, comment and rip it apart. |
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
commit a9c7ce5 Author: Peter G <sailfish@nephros.org> Date: Tue Sep 28 09:19:37 2021 +0200 do not call ssu to determine OS Version See issue sailfishos-patches#33 sailfishos-patches#33 Concept ported from @elros, ac0991b elros34@ac0991b
See issue #33 #33 Concept ported from @elros, ac0991b elros34@ac0991b
Prelude:
As some Patch authors fail to update the information, which SailfishOS releases a specific version of a web-catalog Patch is compatible to (even though that version is compatible to newer SFOS releases), users have practically no choice but to enable Patchmanager's Developer mode.
Observed behavior:
While the update notifications for web-catalog Patches (per system notification, in Patchmanager's top pulley, in PM's list view of the web-catalog and the Patch specific sub-page there) are working as expected, when a device is on the current SailfishOS release.
But when a device has an older SFOS release installed, some web-catalog Patches will have newer versions, which are only compatible to more recent SFOS release(s). One surely does not want to update these Patches.
Still Patchmanager 3.0.55 notifies one via all aforementioned ways, that updates are available.
Suggestion to mitigate this:
When checking for updated Patches from the web-catalog, compare the currently installed SailfishOS release (e.g. per
version | rev | cut -f 2 -d ' ' | rev
, but not perssu re
) with the compatibility information of a Patch, for which an update candidate (i.e. newer version) exists, before generating notifications (i.e. do not notify, if the currently installed SFOS release is not supported by the update candidate).IMO, this extra check always shall be active, regardless of Patchmanager's Developer mode being switched on or off.
Side note: This suggestion is only about when the update notifications are triggered. The ability to install any version of a Patch, when Patchmanager's Developer mode is active is not at all addressed (and shall be retained).
Tested on a Jolla 1 phone under SailfishOS 2.2.1.18 (while SFOS 3.0.0.8 has been released a few weeks ago) with Patchmanager 3.0.55.
P.S.: As issue reports and feature suggestions implicitly always have a slightly negative touch (as proposing to better something), an explicitly positive statement:
Kudos for implementing the multiple, aforementioned ways of notifying that there are update candidates for web-catalog Patches. This is extremely helpful, already.
The text was updated successfully, but these errors were encountered: