Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resolv.conf to /run/connman/resolv.conf #26

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

jokujossai
Copy link

Move resolv.conf to /run/connman/resolv.conf to make resolver configuration available inside sailjail

@jokujossai
Copy link
Author

@jokujossai jokujossai force-pushed the fix-sailjail-resolv branch 2 times, most recently from f45ecdd to 3c4252a Compare April 5, 2022 19:26
Copy link
Contributor

@LaakkonenJussi LaakkonenJussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and as you sent the upstream patches, well, it does not matter if we take this as a big commit. I'll add the annotated tag after merge to contain necessary bits for the build system.

Copy link

@spiiroin spiiroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of cosmetic nits, but: builds, installs, and rectifies the symlink

connman/Makefile.am Outdated Show resolved Hide resolved
rpm/connman.spec Show resolved Hide resolved
@jokujossai jokujossai force-pushed the fix-sailjail-resolv branch 2 times, most recently from db85ff9 to 3587e98 Compare April 7, 2022 09:18
@LaakkonenJussi LaakkonenJussi merged commit ed85424 into sailfishos:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants