-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the use of Emma to Reinstalling Sailfish OS document #287
Add the use of Emma to Reinstalling Sailfish OS document #287
Conversation
Initially, my plan was to add the text about the Emma flashing tool as it has existed in the flashing instruction of Xperia X (Windows) only. Now that I had updated the Xperia X document it came to my mind to describe the Emma tool in this document rather than in the document of a fading product. Eventually, I did not just add the Emma section. The text was an old product of mine from several years back and looked horrible. Reverting a phone back to Android should be the last resort. It is definitely unpleasant for the user. Hopefully, the document is now a little bit easier to understand. I updated the screenshots (and dropped some duplication) and tried to make them visually nicer-looking. There were some hyperlinks missing or incorrect, too, in this document. Apologies, git diff may have difficulties showing the differences. |
The PR title could be a bit more specific. i.e. Which document are we updating? |
Actually, now that I think about it, the whole "Update the document" is kind of pointless. Almost all PRs in this repo update some document. I suggest "Add the use of Emma to Reinstalling Sailfish OS document" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
ba4de63
to
defc756
Compare
All reported issues fixed (afaics). How does it look now? |
Almost there. At least in my opinion - of course it's possible that JP finds something else :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but if you are fixing that one extra full stop then I would propose that on line 165: Should you get a "403 permission denied error" when trying to download,
would be changed to: If you get a "403....
defc756
to
69145ce
Compare
Done. |
Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
69145ce
to
5396964
Compare
I have no more fixes. |
No description provided.