Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the use of Emma to Reinstalling Sailfish OS document #287

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

jovirkku
Copy link
Contributor

@jovirkku jovirkku commented Mar 9, 2023

No description provided.

@jovirkku jovirkku requested a review from vigejolla March 9, 2023 14:15
@jovirkku
Copy link
Contributor Author

jovirkku commented Mar 9, 2023

Initially, my plan was to add the text about the Emma flashing tool as it has existed in the flashing instruction of Xperia X (Windows) only. Now that I had updated the Xperia X document it came to my mind to describe the Emma tool in this document rather than in the document of a fading product.

Eventually, I did not just add the Emma section. The text was an old product of mine from several years back and looked horrible. Reverting a phone back to Android should be the last resort. It is definitely unpleasant for the user. Hopefully, the document is now a little bit easier to understand.

I updated the screenshots (and dropped some duplication) and tried to make them visually nicer-looking. There were some hyperlinks missing or incorrect, too, in this document.
Now we can point precisely to the Emma section from other documents if there is a need to.

Apologies, git diff may have difficulties showing the differences.

@vigejolla
Copy link
Member

The PR title could be a bit more specific. i.e. Which document are we updating?

@vigejolla
Copy link
Member

The PR title could be a bit more specific. i.e. Which document are we updating?

Actually, now that I think about it, the whole "Update the document" is kind of pointless. Almost all PRs in this repo update some document. I suggest "Add the use of Emma to Reinstalling Sailfish OS document"

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
Support/Help_Articles/Reinstalling_Sailfish_OS/README.md Outdated Show resolved Hide resolved
@jovirkku jovirkku changed the title Update the document. Add the use of Emma Add the use of Emma to Reinstalling Sailfish OS document #287 Mar 13, 2023
@jovirkku jovirkku changed the title Add the use of Emma to Reinstalling Sailfish OS document #287 Add the use of Emma to Reinstalling Sailfish OS document Mar 13, 2023
@jovirkku
Copy link
Contributor Author

All reported issues fixed (afaics). How does it look now?

@jovirkku jovirkku requested a review from jpwalden March 13, 2023 08:36
@vigejolla
Copy link
Member

All reported issues fixed (afaics). How does it look now?

Almost there. At least in my opinion - of course it's possible that JP finds something else :)

Copy link
Contributor

@jpwalden jpwalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but if you are fixing that one extra full stop then I would propose that on line 165: Should you get a "403 permission denied error" when trying to download,
would be changed to: If you get a "403....

@jovirkku
Copy link
Contributor Author

Done.

Signed-off-by: Jorma Virkkunen <jorma.virkkunen@jolla.com>
@jovirkku
Copy link
Contributor Author

I have no more fixes.

@vigejolla vigejolla merged commit d913f6b into sailfishos:master Mar 14, 2023
@jovirkku jovirkku deleted the update_Emma_text-jb60339 branch March 14, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants