[embedlite-components] Populate the technical details of the certificate page. JB#56370 OMP#JOLLA-541 #89
Conversation
adenexter
force-pushed
the
jb56370
branch
3 times, most recently
from
e704534
to
6812958
Compare
There was a problem hiding this comment.
These are some really nice changes.
The Finnish and Russian fluent files get installed in /usr/lib64/mozembedlite/chrome/chrome/content/localization/, but when I switch language to Finnish or Russian it doesn't pick up the changes (in the "Technical Details" section). Removing the ~/local/share/org.sailfishl/browser folder doesn't seem to help. Is this intentional behaviour?
It appears that the locale file path substitution is filtered by known available translations. So either a packaged locale as identified by the name appearing in a multilocale.txt file in omni.ja, or an installed language pack. Packaging the language packs would probably be the preferred way forward as it will cover translations for pages that are provided by gecko as well. But that's going to require new mirrors and a packaging repo. |
That's a real pain. It raises the question about whether it's worth shipping the fluent files for fi and ru at all. If I understand correctly, they'll not currently be used. Could they be added at startup using |
Yes, that's what the manifest entry did but doing it manually allows specifying the locales. And now the translations work. |
|
Just a couple of small typos in the commit message, I think. Also fix the caret icon so it's apparent when the collapsed headings have |
|
Rebased and fixed minor comment from @llewelld |
…ate page. JB#56370 OMP#JOLLA-541 The description of the error is no longer encoded in the about:certerror URL and needs to be constructed in the page itself. Also fix the caret icon so it's apparent when the collapsed headings have been expanded as with neither that nor content it wasn't apparent when clicking worked.
Fixed as well |
The description of the error is no longer encoded in the about:certerror
URL and needs to be constructed in the page itself.
Also fix the caret icon so it's apparent when the collapsed headings have
been expanded as with neither that nor content it wasn't apparent when
clicking worked.