[kf5bluezqt] Remove two patches. JB#61506 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed - "Don't connect to signals with QVariantMapMap parameters. Fixes JB#36800" - "Add Manager::monitorObjectManagerInterfaces. Contributes to JB#40602" With the first patch, pairing a bluetooth LE device with pin ended up process stuck. It was introduced to avoid some problem for handling receiving file over bluetooth, but that keeps on working even without. Generally the upstream signal handling code _should_ work already so the patch was somewhat fishy. The latter patch built a bit upon the earlier, but the custom property was used only on one short-lived process. Thus not seeing reason for keeping it. Less delta to upstream is good.
Thaodan
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
With the first patch, pairing a bluetooth LE device with pin ended up process stuck. It was introduced to avoid some problem for handling receiving file over bluetooth, but that keeps on working even without. Generally the upstream signal handling code should work already so the patch was somewhat fishy.
The latter patch built a bit upon the earlier, but the custom property was used only on one short-lived process. Thus not seeing reason for keeping it. Less delta to upstream is good.