[libngf-qt] Avoid emitting playing state twice. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the "play" method over DBus, if the DBus reply is positive, the "playing" state is emitted. Then the ngf daemon is emitting a state change to "playing" which is transmitted by the client. This commit is avoiding to transmit this latter "playing" state in the normal case. If the daemon is unable to play the effect, then the "playing" signal is emitted (because the DBus call succeed) and is then followed by a "failed" signal, thanks to the state change broadcasted by ngfd. This commit is not changing this behaviour.
pvuorela
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the "play" method over DBus, if the
DBus reply is positive, the "playing" state is
emitted. Then the ngf daemon is emitting a state
change to "playing" which is transmitted by the
client. This commit is avoiding to transmit this
latter "playing" state in the normal case.
If the daemon is unable to play the effect, then
the "playing" signal is emitted (because the DBus
call succeed) and is then followed by a "failed"
signal, thanks to the state change broadcasted by
ngfd. This commit is not changing this behaviour.
@pvuorela, this is fixing the played twice that we've seen in the harbour-ding reproducer. As explained in the commit message, I chose to keep the "playing" signal emission in the DBus reply, even if it happens that the effect does not exist for instance. To keep the "playing" -> "failed" workflow.