Switch Nci property type as string. JB#61312 #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main commit:
In addition couple small cleanup commits.
As side-note the existing change signalling here feels excessive with separate signal for each property plus one generic propertyChanged() for int properties. If a cell changes, could assume all the cell properties changing. Only signal strength and that kind of details probably change independently.
Disclaimer: don't have NR to test this with.