Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Nci property type as string. JB#61312 #6

Merged
merged 3 commits into from Mar 19, 2024
Merged

Switch Nci property type as string. JB#61312 #6

merged 3 commits into from Mar 19, 2024

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    1110e75 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. [qofonoext] Switch Nci property type as string. JB#61312

    The qint64 type was problematic:
    - Doesn't work in QML
    - The Invalid64 on enum doesn't work without declaring the
    enum as 64 bit. Which again might not be the best idea for qml.
    - App developer needs to pay close attention whether to use
    32-bit or 64-bit invalid value.
    
    As this isn't getting used in the wild yet, let's just switch
    the nci property as string for now. If there are c++ needs, a
    separate getter can be added later.
    
    The general 64-bit storage just because of one wider property, now
    needing more special handling, felt heavy. Switched back to 32-bit and
    using separate property for nci. Wouldn't expect new radio
    technologies with new properties too soon.
    pvuorela committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    dc77ec9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d1d9fb View commit details
    Browse the repository at this point in the history