Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nemo-qml-plugin-calendar] Only check notebook validity at calendar l… #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcaliste
Copy link
Contributor

…evel.

There is no need to check for runtime-ness of
the notebook here, it is done at mKCal level
when saving an incidence already.

It is harmfull to check for readonly-ness of
the notebook though, since the read-only
status is only a hint. One should be able to
save modifications in a read-only notebook
when these modifications make sense (like
setting a reminder in the birthday calendar).

It is required to check that the notebook
exists in the calendar, since this check is
not done in mKCal at DB level.

…evel.

There is no need to check for runtime-ness of
the notebook here, it is done at mKCal level
when saving an incidence already.

It is harmfull to check for readonly-ness of
the notebook though, since the read-only
status is only a hint. One should be able to
save modifications in a read-only notebook
when these modifications make sense (like
setting a reminder in the birthday calendar).

It is required to check that the notebook
exists in the calendar, since this check is
not done in mKCal at DB level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant