Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sb2] Conditionally accelerate ccache. JB#61370 #24

Merged
merged 1 commit into from Jan 10, 2024
Merged

[sb2] Conditionally accelerate ccache. JB#61370 #24

merged 1 commit into from Jan 10, 2024

Conversation

vigejolla
Copy link
Member

meson incorrectly tries to use ccache if it's accelerated even when it does not exist

@vigejolla
[sb2] Conditionally accelerate ccache. JB#61370
75bbb13 
meson incorrectly tries to use ccache if it's accelerated even when it
does not exist

Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
@vigejolla vigejolla mentioned this pull request Jan 9, 2024
Merged
Thaodan
Thaodan approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Maybe the ccache rule also should also go to the other modes.

@vigejolla vigejolla merged commit 20befb6 into master Jan 10, 2024
@pvuorela pvuorela mentioned this pull request Jan 11, 2024
Merged
@mlehtima mlehtima deleted the jb61370 branch March 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thaodan Thaodan Thaodan approved these changes

@pvuorela pvuorela Awaiting requested review from pvuorela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vigejolla @Thaodan