interface should define either direction or add annotation for both directions

[jmlich]

The Qt6 qdbusxml2cpp seems to be more strict about annotations and complains on missing annotation for both directions.

$ /usr/lib/qt6/bin/qdbusxml2cpp -N -c QUsbModedInterface -p usb_moded_interface.h: /usr/include/usb-moded/com.meego.usb_moded.xml
dbus.parser: Invalid D-BUS object path '//com/meego/usb_moded' found while parsing introspection
qdbusxml2cpp: Got unknown type `a{sv}' processing '/usr/include/usb-moded/com.meego.usb_moded.xml'
You should add <annotation name="org.qtproject.QtDBus.QtTypeName.Out0" value="<type>"/> to the XML description for 'config'

Related part of the xml looks like this:

    <signal name="sig_usb_taget_mode_config_ind">
      <arg name="config" type="a{sv}" />
      <annotation name="org.qtproject.QtDBus.QtTypeName.In0" value="QVariantMap"/>
    </signal>

The fix should either add direction like this:

    <signal name="sig_usb_taget_mode_config_ind">
      <arg name="config" type="a{sv}" direction="in"/>
      <annotation name="org.qtproject.QtDBus.QtTypeName.In0" value="QVariantMap"/>
    </signal>

Either add annotation for both directions.

    <signal name="sig_usb_taget_mode_config_ind">
      <arg name="config" type="a{sv}" />
      <annotation name="org.qtproject.QtDBus.QtTypeName.In0" value="QVariantMap"/>
      <annotation name="org.qtproject.QtDBus.QtTypeName.Out0" value="QVariantMap"/>
    </signal>

My best guess is that annotations for both directions will not break anything, but I am not familiar with usb-moded code enough to be 100% sure.

[Thaodan]

Similar to sailfishos/libconnman-qt#20. Should be safe.

[pvuorela]

Using my desktop Qt 6.6.0 qdbus tool I'm not getting any complaints. And then as mentioned signals should be already implicitly 'out' parameters.

For In0 came across this https://techbase.kde.org/Development/Tutorials/D-Bus/CustomTypes -- Sounds like that annotation can be used interchangeably with Out0.

So I'm not sure is there really anything needing changes here.

[spiiroin]

So I'm not sure is there really anything needing changes here.

There is the actual fix part i.e. changing "In0" -> "Out0" removes the compilation time warning -> LGTM.

Then there is unnecessary addition of "direction=out". Which is not wrong. But it also makes that one signal definition differ from all the other signals. So for the sake of consistency -> I'd rather would not to have this.

[spiiroin]

Fixes the reported problem.
Still has a minor cosmetic issue, but that is not a show stopper. Can be merged.