Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version command on binary #69

Open
Etiene opened this issue Jan 23, 2016 · 7 comments
Open

Add version command on binary #69

Etiene opened this issue Jan 23, 2016 · 7 comments

Comments

@Etiene
Copy link
Member

Etiene commented Jan 23, 2016

@xspager
Copy link
Contributor

xspager commented Feb 10, 2016

Should adding more dependencies be avoided or can this https://github.com/amireh/lua_cliargs be used?

@louis77
Copy link
Contributor

louis77 commented Feb 19, 2016

https://github.com/amireh/lua_cliargs looks great. I guess the sailor CLI will grow over time so a library like this could be useful. I don't see any problem with dependencies to mature projects, are you?

@Etiene
Copy link
Member Author

Etiene commented Feb 24, 2016

Yes, I agree using cliargs is a good call

@xspager
Copy link
Contributor

xspager commented Feb 28, 2016

Had a quick look at this but I found a big block, the lua_cliargs version for the latest version busted don't support commands.

UPDATE: Opened a Issue there: lunarmodules/busted#498

@mpeterv
Copy link
Contributor

mpeterv commented Feb 28, 2016

Shameless plug, there is another CLI parsing library that supports commands. Although waiting for release of busted-2.0.rc12 is probably better if you don't want to indirectly depend on two different libraries that do the same thing.

@xspager
Copy link
Contributor

xspager commented Feb 28, 2016

Nice! Will try it. :)
Em 28/02/2016 10:03 AM, "Peter Melnichenko" notifications@github.com
escreveu:

Shameless plug, there is another CLI parsing library that supports
commands https://github.com/mpeterv/argparse. Although waiting for
release of busted-2.0.rc12 is better if you don't to indirectly depend on
two different libraries that do same thing.


Reply to this email directly or view it on GitHub
#69 (comment)
.

@xspager
Copy link
Contributor

xspager commented Mar 2, 2016

Started a refactor using argparse as suggested by @mpeterv, check the branch https://github.com/sailorproject/sailor/compare/master...xspager:cli_refactor?expand=1

Still need verify if the behavior is similar to the old one and get the messages and more close to what it is right now.

@Etiene, can you change the points of this issue and the title to something more generic? :)

Feedback welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants