PLTCONN-3883: Implement changes to support Direct permission config in connector spec that will show up in UI #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec that will show up in UI
…ec that will show up in UI
…ec that will show up in UI
|
|
…ec that will show up in UI
lib/commands/command.ts
Outdated
| @@ -157,5 +163,5 @@ export type AccountSchema = Schema & { | |||
| * Entitlement schema | |||
| */ | |||
| export type EntitlementSchema = Schema & { | |||
| type: string | |||
| type: string, | |||
There was a problem hiding this comment.
Do we want to add the boolean flag here also?
lib/commands/std-entitlement-list.ts
Outdated
| @@ -18,5 +18,6 @@ export type StdEntitlementListInput = { | |||
| export type StdEntitlementListOutput = ObjectOutput & { | |||
| type: string | |||
| deleted?: boolean | |||
| attributes: Attributes | |||
| attributes: Attributes, | |||
| permissions: Permission[] | |||
There was a problem hiding this comment.
What about the entitlement read command? Also if we want to have permission as part of the attribute, we don't need to worry about it here at all
…tor spec that will show up in UI
fangming-ning-sp
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the intent of this change and why is it being made?
Add permissions to entitlements
How Has This Been Tested?
What testing have you done to verify this change?
Manual testing