Improve CSP compatibility with colorbox theme #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done for Galleria theme in commit 96d6623.
Main purpose is to fix problems with Content Security Policy, that makes difficult to work with inline code.
|
Great, thanks @jasuarez ! |
kontza
pushed a commit
to kontza/sigal
that referenced
this pull request
Aug 28, 2020
Improve CSP compatibility with colorbox theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for colorbox theme helps to improve CSP compatibility.
Main problem is that CSP makes harder to work with static inline code, which is used in the theme.
So basically we move that code to external files, and load it in the template.
This can be considered part of fix for issue #178, at least for colorbox theme. But I think this very same idea can be applied to the other themes.