Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbox improvements #152

Closed
wants to merge 2 commits into from
Closed

Conversation

jasuarez
Copy link
Contributor

A couple of minor improvements for colorbox theme:

  • Show video title instead of video filename when opening a video.
  • As it is done for albums, lets write below each media its title.

@saimn
Copy link
Owner

saimn commented Mar 22, 2015

I have tested this, the idea is fine but when some images have a title and other don't this introduce a gap between images. To solve this one could use the height of images, but I'm not sure of the best way to do this. I will look if I find some time.

@jasuarez
Copy link
Contributor Author

I've managed to reproduce the same issue, but in a different way: having different lengths in the title can also raise the problem.

When clicking a video, show the title (if available) instead of
filename, as it is done for images.
As we do for albums, let's write the media title below the thumbnail,
for easy identification.
@jasuarez
Copy link
Contributor Author

Rebased PR against latest master

@saimn
Copy link
Owner

saimn commented Jun 22, 2015

Hi @jasuarez ,

@jasuarez jasuarez closed this Jan 25, 2017
@jasuarez jasuarez deleted the colorbox-improvements branch January 25, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants