Honor use_orig with videos
#153
Conversation
| outname = os.path.join(outpath, filename) | ||
| utils.copy(source, outname, symlink=settings['orig_link']) | ||
| return outname | ||
|
|
There was a problem hiding this comment.
This should probably go at the beginning of process_video, as it would avoid to modify the path here and avoid to return a modified filename.
There was a problem hiding this comment.
Correct. I added it in generate_video because the same is done in generate_image. But I'll move it to process_video.
|
Thanks for this PR, it is indeed something that was missing (as other feature like mp4/multiple format support). |
|
Hi @jasuarez , |
|
i'm bit busy these weeks, but I'll try to address your comments this weekend |
jasuarez
force-pushed
the
honor-use_orig-with-videos
branch
from
e2aeac9
to
2be7878
Compare
|
@saimn Re-created the PR addressing your comments, plus rebasing against latest master. |
jasuarez
force-pushed
the
honor-use_orig-with-videos
branch
2 times, most recently
from
2be7878
to
8d70776
Compare
|
Thanks @jasuarez ! Could you just revert the change in test_video as it should no more be necessary ? |
|
Also please add yourself to AUTHORS ;) |
When 'use_orig' is True, copy the original video files (or symlink them, depending if 'orig_link' is True) to the destination, and use them as they are, without processing. This setting is ignored for all files not supported in HTML5; those are converted anyway, because otherwise we could not reproduce them.
As we can use the videos as they are, without conversion, we need to set the video type correctly.
jasuarez
force-pushed
the
honor-use_orig-with-videos
branch
from
8d70776
to
0a3198b
Compare
|
@saimn I need to push the change in |
|
Thanks, merged in 2f90da5
No, before all tests shared the settings dict, but since a recent change on master there is a settings doct for each test. |
So far
use_origis totally ignored for the case of videos.But giving that lot of times we have a big amount of videos that we don't want to process because it is expensive, or they are already web-friendly.
This set of commits makes
use_origto be respected in case of videos.I was doubting between following this, or adding a new
video_use_orig(andvideo_orig_link). But at the end I decided to use the same property for both cases.