New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlcude tests in PyPI tarball #323

Merged
merged 1 commit into from Sep 5, 2018

Conversation

2 participants
@dotlambda
Copy link
Contributor

dotlambda commented Apr 8, 2018

The tests are useful for downstream packagers and do not hurt normal users (because they are usually not run).

Inlcude tests in PyPI tarball
The tests are useful for downstream packagers and do not hurt normal users (because they are usually not run).
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #323 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   87.81%   87.74%   -0.08%     
==========================================
  Files          19       19              
  Lines        1412     1412              
==========================================
- Hits         1240     1239       -1     
- Misses        172      173       +1
Impacted Files Coverage Δ
sigal/plugins/watermark.py 90.69% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6843ce...417d025. Read the comment docs.

@saimn

This comment has been minimized.

Copy link
Owner

saimn commented Jun 4, 2018

Sorry for the delay!
Right now I prefer not to accept this because I'm not completely sure of the license of all the images present there. It has been on my todo list to check this since a long time but ...
Also I'm not convinced that it is useful to add ~4Mb to the package, as the majority of the users will not run the tests this way. It's not huge but if every package does the same the site-packages is quickly growing in size for no real gain.

@saimn

This comment has been minimized.

Copy link
Owner

saimn commented Sep 5, 2018

Ok, now that I checked the included images and video (#340), let's move forward and merge this. Thanks @dotlambda !

@saimn saimn merged commit 582f101 into saimn:master Sep 5, 2018

2 of 3 checks passed

codecov/project 87.74% (-0.08%) compared to d6843ce
Details
codecov/patch Coverage not affected when comparing d6843ce...417d025
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment