-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinBar highlight is off in Neovim 0.10 #203
Comments
Thanks for reporting! I'll have a look before next week. |
I found the culprit: neovim/neovim#26921 I am not yet sure what visual appearance this bar should have. In Neovim's default colorscheme, the authors decided to use a style which differs significantly from the statusline:
I think I'm going to try something similar in gruvbox-material for a start. |
@sarmong would you mind adding this vim.api.nvim_create_autocmd('ColorScheme', {
group = vim.api.nvim_create_augroup('custom_highlights_gruvboxmaterial', {}),
pattern = 'gruvbox-material',
callback = function()
local config = vim.fn['gruvbox_material#get_configuration']()
local palette = vim.fn['gruvbox_material#get_palette'](config.background, config.foreground, config.colors_override)
local set_hl = vim.fn['gruvbox_material#highlight']
set_hl('WinBar', palette.grey2, palette.bg_dim, 'bold')
set_hl('WinBarNC', palette.grey1, palette.bg_dim)
end
}) |
With so many possible bars on the screen I feel that it's going to be hard to please everyone 😅 I think I'm going to gate this behind an option like One of the thing which bothered me, while trying to default to the same color as the statusline, is that the winbar of the lower window seemed to be "merging" with the statusline of the upper window. edit: note that if I make the winbar lighter, it is likely to have the same color as your active tab. |
For the sake of having some (arguably) reasonable default in the colorscheme, I went ahead and linked In case we want to be opinionated and offer multiple default winbar styles to users, we can do that in a separate proposal. However, I would argue that statuslines and other bars (winbar, tabbar) are so often customized using plugins that we should probably stay away from trying to style them ourselves. One example is the |
Actually, I found a problem with linking WinBar to StatusLine when using I know it is impossible to fit every usecase, but maybe solution to just duplicate highlighting from StatusLine to WinBar will work better than linking it? |
@sarmong sure this shouldn't be a problem. |
Maybe another thing worth considering - is making the text bold? Before the change (in 0.9) it was bold |
Fully agree. It's indeed bold by default, and in #203 (comment) I also suggested to make it bold, the attribute simply got lost while linking. |
Adjust the style of the winbar based the user's configuration (style and transparency), similarly to the statusline. The WinBar highlight group is deliberately left unlinked from StatusLine to avoid changes by plugins to have undesired side effects on the winbar. Ref. #203
@sarmong the change is now on |
Thank you |
Adjust the style of the winbar based the user's configuration (transparency), similarly to the statusline. The WinBar highlight group is deliberately left unlinked from StatusLine to avoid changes by plugins to have undesired side effects on the winbar. Ref. sainnhe/gruvbox-material#203
Adjust the style of the winbar based the user's configuration (transparency), similarly to the statusline. The WinBar highlight group is deliberately left unlinked from StatusLine to avoid changes by plugins to have undesired side effects on the winbar. Ref. sainnhe/gruvbox-material#203
Adjust the style of the winbar based the user's configuration (transparency), similarly to the statusline. The WinBar highlight group is deliberately left unlinked from StatusLine to avoid changes by plugins to have undesired side effects on the winbar. Ref. sainnhe/gruvbox-material#203
I have done the following steps before reporting this issue:
Neovim 0.10 sets default highlighting for
WinBar
thus making active winbar black.The text was updated successfully, but these errors were encountered: