feat: make redirects via the input component case-insensitive #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cca168c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonathaningram
requested changes
Feb 7, 2023
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
from
63fc196
to
2e1858c
Compare
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
from
2e1858c
to
9966eb0
Compare
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
from
013e4ae
to
fe9ea75
Compare
jonathaningram
requested changes
Feb 7, 2023
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
2 times, most recently
from
d639f4d
to
918b429
Compare
jonathaningram
requested changes
Feb 7, 2023
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
from
918b429
to
feb83e2
Compare
jonathaningram
previously approved these changes
Feb 8, 2023
jkaho
changed the title
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
4 times, most recently
from
310397a
to
9ec2442
Compare
|
@jonathaningram sorry needed to rejig the test since it was passing locally but failing in the CI check |
jkaho
force-pushed
the
DAU-249/lowercase-input-to-look-up-redirects
branch
from
9ec2442
to
cca168c
Compare
jonathaningram
approved these changes
Feb 8, 2023
jkaho
added a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume users don't care about the case-sensitivity of redirects and lowercase all inputs when retrieving redirects, as well as the redirect keys themselves (the queries that trigger the redirects).
DAU-249