SAK-48820 Scheduler SoftSiteDeletionJob deleting AuthzGroups for groups #11546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
approved these changes
May 9, 2023
ern
reviewed
May 9, 2023
| @@ -115,7 +115,8 @@ public void execute(JobExecutionContext jobExecutionContext) | |||
|
|
|||
| try { | |||
| enableSecurityAdvisor(); | |||
|
|
|||
| //load in groups for removal of authzGroups | |||
| s.getGroups(); | |||
There was a problem hiding this comment.
This is very strange that the removeSite would act differently because getGroups was called before it! This sounds like a bug in the SiteService, will look into this.
There was a problem hiding this comment.
@ern did you ever look into this?
There was a problem hiding this comment.
let's merge this ... it sounds like an improvement with little chance of introducing a new bug or regression
ern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete AuthzGroups for groups when running he “Expunge softly deleted sites“ job for softly deleted site.