Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-48820 Scheduler SoftSiteDeletionJob deleting AuthzGroups for groups #11546

Merged
merged 1 commit into from
May 29, 2024
Merged

SAK-48820 Scheduler SoftSiteDeletionJob deleting AuthzGroups for groups #11546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...nt-shared/src/java/org/sakaiproject/component/app/scheduler/jobs/SoftSiteDeletionJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ public void execute(JobExecutionContext jobExecutionContext)

try {
enableSecurityAdvisor();

//load in groups for removal of authzGroups
s.getGroups();
Copy link
Contributor

@ern ern May 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very strange that the removeSite would act differently because getGroups was called before it! This sounds like a bug in the SiteService, will look into this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ern did you ever look into this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this ... it sounds like an improvement with little chance of introducing a new bug or regression

siteService.removeSite(s, hardDelete);
log.info("Removed site: " + s.getId());

Expand Down
Loading