Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect fling velocity on zoom gesture end with Compose 1.7.0-alpha02 #71

Closed
FooIbar opened this issue Mar 2, 2024 · 1 comment · Fixed by #76
Closed

Incorrect fling velocity on zoom gesture end with Compose 1.7.0-alpha02 #71

FooIbar opened this issue Mar 2, 2024 · 1 comment · Fixed by #76

Comments

@FooIbar
Copy link
Contributor

FooIbar commented Mar 2, 2024

fling.mp4

VelocityTrackerAddPointsFix is enabled by default since Compose UI 1.7.0-alpha02.
Currently we set this flag to false as a workaround, but it will be removed in the future.

Related bug: https://issuetracker.google.com/269487059
savvasdalkitsis added a commit to savvasdalkitsis/uhuruphotos-android that referenced this issue Mar 13, 2024
@savvasdalkitsis
Reverting to compose 1.6.3 to fix issue with lightbox zoom fling (sak…
00105d2 
…et/telephoto#71)
@FooIbar
Copy link
Contributor Author

FooIbar commented Mar 17, 2024

I believe this is caused by

telephoto/zoomable/src/commonMain/kotlin/me/saket/telephoto/zoomable/internal/transformable.kt

Lines 197 to 199 in 1749177

event.changes.fastForEach {
velocityTracker.addPointerInputChange(it)
}

where changes from different pointers are added to the same VelocityTracker.

@FooIbar FooIbar mentioned this issue Mar 18, 2024
Merged
@saket saket closed this as completed in #76 Apr 4, 2024
ZacSweers pushed a commit to ZacSweers/CatchUp that referenced this issue Apr 15, 2024
@renovate
Update telephoto to v0.10.0 (#1379)
5333c46 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[me.saket.telephoto:zoomable-image-coil](https://togithub.com/saket/telephoto)
| `0.9.0` -> `0.10.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/me.saket.telephoto:zoomable-image-coil/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/me.saket.telephoto:zoomable-image-coil/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/me.saket.telephoto:zoomable-image-coil/0.9.0/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/me.saket.telephoto:zoomable-image-coil/0.9.0/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[me.saket.telephoto:zoomable-image](https://togithub.com/saket/telephoto)
| `0.9.0` -> `0.10.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/me.saket.telephoto:zoomable-image/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/me.saket.telephoto:zoomable-image/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/me.saket.telephoto:zoomable-image/0.9.0/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/me.saket.telephoto:zoomable-image/0.9.0/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [me.saket.telephoto:zoomable](https://togithub.com/saket/telephoto) |
`0.9.0` -> `0.10.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/me.saket.telephoto:zoomable/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/me.saket.telephoto:zoomable/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/me.saket.telephoto:zoomable/0.9.0/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/me.saket.telephoto:zoomable/0.9.0/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>saket/telephoto
(me.saket.telephoto:zoomable-image-coil)</summary>

###
[`v0.10.0`](https://togithub.com/saket/telephoto/releases/tag/0.10.0)

[Compare
Source](https://togithub.com/saket/telephoto/compare/0.9.0...0.10.0)

Bug fixes

-
[saket/telephoto#70,
[saket/telephoto#72:
Correctly update `ZoomableState` when `Modifier.zoomable()` is reused
-
[saket/telephoto#71:
Make sure velocity tracker tracks the same pointer
-
[saket/telephoto#81:
Read maximum fling velocity from composition locals

Dependency updates

-   Compose compiler: 1.5.11
-   Compose UI: 1.6.4
-   Compose multiplatform: 1.6.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ZacSweers/CatchUp).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to slackhq/circuit that referenced this issue Apr 16, 2024
@slack-oss-bot
Update dependency me.saket.telephoto:zoomable-image-coil to v0.10.0 (#…
bb7cb35 
…1339)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[me.saket.telephoto:zoomable-image-coil](https://togithub.com/saket/telephoto)
| dependencies | minor | `0.9.0` -> `0.10.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>saket/telephoto
(me.saket.telephoto:zoomable-image-coil)</summary>

###
[`v0.10.0`](https://togithub.com/saket/telephoto/releases/tag/0.10.0)

[Compare
Source](https://togithub.com/saket/telephoto/compare/0.9.0...0.10.0)

Bug fixes

-
[saket/telephoto#70,
[saket/telephoto#72:
Correctly update `ZoomableState` when `Modifier.zoomable()` is reused
-
[saket/telephoto#71:
Make sure velocity tracker tracks the same pointer
-
[saket/telephoto#81:
Read maximum fling velocity from composition locals

Dependency updates

-   Compose compiler: 1.5.11
-   Compose UI: 1.6.4
-   Compose multiplatform: 1.6.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure velocity tracker tracks the same pointer FooIbar/telephoto
1 participant
@FooIbar