Fixes an issue in with placeholder sizing. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saket
approved these changes
Apr 24, 2024
zoomable-image/coil/src/androidTest/assets/night_watch_14000.jpg
Outdated
Show resolved
Hide resolved
saket
reviewed
Apr 24, 2024
| ) | ||
| .build() | ||
| ) | ||
| val source = object : ZoomableImageSource { |
There was a problem hiding this comment.
I'm slightly surprised this does not need to be remembered.
There was a problem hiding this comment.
Hmm, I suppose that it's not storing any state internally that requires remembering, so even if it gets recreated on recomposition it is still doing the right thing?
There was a problem hiding this comment.
Ah right, I often forget that the compose compiler only looks at functions. From its perspective, resolve() does not require a new composition branch even if the ZoomableImageSource instance is updated.
github-merge-queue bot
pushed a commit
to slackhq/circuit
that referenced
this pull request
Apr 28, 2024
…1373) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [me.saket.telephoto:zoomable-image-coil](https://togithub.com/saket/telephoto) | dependencies | minor | `0.10.0` -> `0.11.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>saket/telephoto (me.saket.telephoto:zoomable-image-coil)</summary> ### [`v0.11.2`](https://togithub.com/saket/telephoto/releases/tag/0.11.2) Bug fixes - [saket/telephoto#84: Fixed an issue causing placeholders to sometimes take up the full screen (by [@​rharter](https://togithub.com/rharter)) - [saket/telephoto#37: Prevent a crash in `ZoomableAsyncImage()` after the app's disk cache is cleared - [saket/telephoto#83: Correctly display single-frame GIFs New changes - Increase memory cache hit rate with Coil by using `Precision.INEXACT` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjYuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
ZacSweers
pushed a commit
to ZacSweers/CatchUp
that referenced
this pull request
Apr 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [me.saket.telephoto:zoomable-image-coil](https://togithub.com/saket/telephoto) | `0.10.0` -> `0.11.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [me.saket.telephoto:zoomable-image](https://togithub.com/saket/telephoto) | `0.10.0` -> `0.11.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [me.saket.telephoto:zoomable](https://togithub.com/saket/telephoto) | `0.10.0` -> `0.11.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>saket/telephoto (me.saket.telephoto:zoomable-image-coil)</summary> ### [`v0.11.2`](https://togithub.com/saket/telephoto/releases/tag/0.11.2) Bug fixes - [saket/telephoto#84: Fixed an issue causing placeholders to sometimes take up the full screen (by [@​rharter](https://togithub.com/rharter)) - [saket/telephoto#37: Prevent a crash in `ZoomableAsyncImage()` after the app's disk cache is cleared - [saket/telephoto#83: Correctly display single-frame GIFs New changes - Increase memory cache hit rate with Coil by using `Precision.INEXACT` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/CatchUp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases in which the placeholder's intrinsic size is updated, the preview would not be updated to use that size. When using an
AsyncImagePainterfrom Coil, this results in the theLoadingstate's empty size being used to calculate the placeholder position iff the content size is resolved before the placeholder, causing the placeholder to fill the view.This change fixes that issue by adding the placeholder's
intrinsicSizeas a key for theFixedSizePainter's remember call.