Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified css #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

modified css #7

wants to merge 1 commit into from

Conversation

ShobhitRathi
Copy link

Hi, I've modified your CSS and made your website more professional and elegant
what I've done is

  1. change the font to Poppins as it is more readable and professional
  2. edited hover effects and buttons
  3. sticked with the colour scheme which you chose
  4. added smooth scroll effect fro the website and other misc.

PR made for issue #1

@ShobhitRathi
Copy link
Author

HII @sakshigupta06 are you going to merge it then?

@sakshigupta06
Copy link
Owner

Thankyou for your contribution @ShobhitRathi , but your changes are conflicting with my main branch. But I have look into the changes you have made I'll try to include them in my Portfolio. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isha2103 Isha2103 Isha2103 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShobhitRathi @sakshigupta06 @Isha2103