find-tools.bat のドキュメントを修正する #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
berryzplus
reviewed
May 3, 2021
tools/find-tools.md
Outdated
|
|
||
| 1. python Launcher(py.exe)が存在し、`py.exe --version`でバージョンが取れたら、それを使う。 | ||
| 1. Python launcher (py.exe) が存在し、 `py.exe --version` でバージョンが取れたら、それを使う。 |
There was a problem hiding this comment.
Python Launcher（Lは大文字）のようです。
https://docs.python.org/3/using/windows.html
- CMake と Ninja を外部ツールの一覧に追加した - 固有名詞における文字の大小を区別するようにした
|
レビューありがとうございます。 （余談） |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
検索対象の外部ツールに関する説明に CMake と Ninja を追加します。
カテゴリ
PR の背景
find-tools.bat という、外部ツールのパスを検索するツールがあります。
#1227 で CMake と Ninja もこのツールで検索できるようになりましたが、例によってドキュメントに反映されていませんでした。
（本件は #1630 の対応過程で見つけました。）
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
PR の影響範囲
テスト内容
テスト1
手順
関連 issue, PR
参考資料