リビルド時、githash.hが再生成されるように修正 #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
・クリーンでgithash.hを削除するターゲットの追加
berryzplus
force-pushed
the
feature/recreate_githash_on_rebuild
branch
from
6d5d9c9
to
66cfd37
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
✅ Build sakura 1.0.4293 completed (commit 1d0215ae65 by @berryzplus) |
|
✅ Build sakura 1.0.4294 completed (commit 2a95ab1e3b by @berryzplus) |
|
Build時に sakura_core フォルダに作られる githash.h ファイルが Clean で消える事を確認しました。問題無いと思います。 |
beru
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
仕様・動作説明
sakura.vcxprojにビルドターゲットを追加する変更です。githash.hをクリーン時に削除されるようにします。PR の影響範囲
sakura.vcxprojのクリーンとビルドに影響する変更です。テスト内容
（ビルドした状態から空コミットしてリビルドするとハッシュが変わる。）
関連 issue, PR
参考資料