fixed readme typos js formatting issues #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltaidea
reviewed
Jun 7, 2017
README.md
Outdated
| electron-packager . "SecureLogin" --osx-sign --overwrite --arch=x64 --icon=www/electron.icns | ||
| electron-installer-dmg SecureLogin-darwin-x64/SecureLogin.app SecureLogin | ||
| ``` | ||
|
|
||
| For MAS | ||
| ``` | ||
| For MAC |
There was a problem hiding this comment.
Ok. That should be written explicit then, I guess. Not obvious at all.
README.md
Outdated
| { | ||
| sltoken: SecureLogin(), //returns state and opens the app | ||
| authenticity_token: csrf | ||
| }, |
There was a problem hiding this comment.
I'm all for generous spacing, but this is taking it too far IMO.
README should be concise.
There was a problem hiding this comment.
I've just used prettier formatting guidelines.
|
@lamaster thanks, protocol was changed dramatically and I just noticed this one so closing it... Btw what's with === vs ==? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.