Patches for missing dependencies and client updates #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some small updates, after the talks of yesterday.
Missing Dependencies in
package.json
(ce9a826)I've installed SwarmESB with
quickrun.sh
, and when the adaptor is started (node adapters/demoLaunch.js
), several dependencies are missing, namely:jsonwebtoken
connect
connect-route
(error displayed only ifconnect
is installed)Client address and socket.io version (91e97f9)
localhost
won't work, so ratherwindow.location.hostname
would (it takes the domain name without scheme -http://
or port, eg:http://domain.name:8080
=>domain.name
) - this allows the client to run both on localhost and on a cloud instance such as EC2 (provided the client is on the same machine as the ESB)1.0.6
is not compatible with the config, while2.0.1
works.gitignore (02c33c4)
To avoid further commits with
node_modules/*
or withlogs/*
.