Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for missing dependencies and client updates #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Patches for missing dependencies and client updates #20

wants to merge 3 commits into from

Conversation

xR86
Copy link

@xR86 xR86 commented Jun 15, 2017

I've made some small updates, after the talks of yesterday.

Missing Dependencies in package.json (ce9a826)

image
I've installed SwarmESB with quickrun.sh, and when the adaptor is started (node adapters/demoLaunch.js), several dependencies are missing, namely:

  • jsonwebtoken
  • connect
  • connect-route (error displayed only if connect is installed)

Client address and socket.io version (91e97f9)

  • the client address being hardcoded to localhost won't work, so rather window.location.hostname would (it takes the domain name without scheme - http:// or port, eg: http://domain.name:8080 => domain.name) - this allows the client to run both on localhost and on a cloud instance such as EC2 (provided the client is on the same machine as the ESB)
  • socket.io version 1.0.6 is not compatible with the config, while 2.0.1 works

.gitignore (02c33c4)

To avoid further commits with node_modules/* or with logs/*.

@mateimicu
Copy link

I also faced this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants