Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception when type is None #32

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Raise an exception when type is None #32

merged 1 commit into from
Jun 6, 2023

Commits on Jun 5, 2023

  1. Raise an exception when type is None 

    As the parameter type can be None in ContextMenu, it's unclear
at first glance why creating a ContextMenu without a type, and
calling compile on it, raises the exception
"'NoneType' object has no attribute 'upper'".

cm = ContextMenu("Name")
cm.compile() <- exception

This change adds a better error message for when compile is
called on the top-level ContextMenu, so that it's more clear
what the problem is

Ref saleguas#31
    @Nauja
    Nauja committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a67fb44 View commit details
    Browse the repository at this point in the history