Raise an exception when type is None #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the parameter type can be None in ContextMenu, it's unclear
at first glance why creating a ContextMenu without a type, and
calling compile on it, raises the exception
"'NoneType' object has no attribute 'upper'".
cm = ContextMenu("Name")
cm.compile() <- exception
This change adds a better error message for when compile is
called on the top-level ContextMenu, so that it's more clear
what the problem is
Ref saleguas#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the parameter
typecan beNonein ContextMenu, it's unclear at first glance why creating a ContextMenu without atype, and calling compile on it, raises the exception'NoneType' object has no attribute 'upper'.This change adds a better error message for when compile is called on the top-level ContextMenu, so that it's more clear what the problem is
Ref #31