Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMS hub app #262

Merged
merged 11 commits into from
Mar 16, 2023
Merged

Add CMS hub app #262

merged 11 commits into from
Mar 16, 2023

Conversation

orzechdev
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

⚠️ No Changeset found

Latest commit: 475a5a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 10:14AM (UTC)
saleor-app-search 🔄 Building (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-taxes ✅ Ready (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
saleor-app-data-importer ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-emails-and-messages ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-invoices ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-klaviyo ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-monitoring ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-products-feed ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)
saleor-app-slack ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 10:14AM (UTC)

Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested, will continue review

apps/cms/.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
apps/cms/.gitignore Outdated Show resolved Hide resolved
apps/cms/CODEOWNERS Outdated Show resolved Hide resolved
apps/cms/.prettierrc Outdated Show resolved Hide resolved
apps/cms/LICENSE Outdated Show resolved Hide resolved
apps/cms/package.json Outdated Show resolved Hide resolved
apps/cms/src/DashboardActions.tsx Outdated Show resolved Hide resolved
apps/cms/src/lib/app/redirect.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/clients-execution.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/clients-execution.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/clients-operations.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/metadata-execution.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/operations.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/settings.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/client-utils/settings.ts Outdated Show resolved Hide resolved
apps/cms/src/lib/cms/config.ts Outdated Show resolved Hide resolved
Comment on lines +1 to +9
export interface ChannelsLoading {
fetching: boolean;
saving: boolean;
}

export interface ChannelsErrors {
fetching?: Error | null;
saving?: Error | null;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't react-query provide these states?

apps/cms/src/modules/ui/app-dashboard-link.tsx Outdated Show resolved Hide resolved
apps/cms/src/pages/api/webhooks/product-variant-created.ts Outdated Show resolved Hide resolved
Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good , lets merge and deploy it to staging for some QA. Next improvements can be done in upcoming PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants